Skip to content

Add bindings for git_reference_normalize_name #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2020

Conversation

kim
Copy link
Contributor

@kim kim commented Sep 15, 2020

Occasionally useful to be able to specify the git_reference_format_t flags.

The effect of the flags is not always intuitive -- let me know if the examples
given are too much, or too less.

@kim
Copy link
Contributor Author

kim commented Sep 15, 2020

Hm, not sure why Windows CI is complaining.

@ehuss
Copy link
Contributor

ehuss commented Sep 15, 2020

enums don't necessarily have a specific integer type in C. The flags parameter in git_reference_normalize_name needs to match the type in the C definition (unsigned int).

Also, run cargo run --manifest-path systest/Cargo.toml to verify the types are defined correctly.

@kim
Copy link
Contributor Author

kim commented Sep 16, 2020

Thanks @ehuss!

@alexcrichton
Copy link
Member

Looks good to me, thanks!

@alexcrichton alexcrichton merged commit 95c243f into rust-lang:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants